search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.63k stars 3.56k forks source link

GH-43080: [CI][Dev] Enable shellcheck #44724

Closed kou closed 1 week ago

kou commented 1 week ago

Rationale for this change

shellcheck is a shell linter. It will find some potential problems in CI.

What changes are included in this PR?

We should enable shellcheck lint for all shell scripts eventually.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

github-actions[bot] commented 1 week ago

:warning: GitHub issue #43080 has been automatically assigned in GitHub to PR creator.

conbench-apache-arrow[bot] commented 1 week ago

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 3b3af5d76e4fd6fe2a0653d6385ff45933f8e44e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.