GH-44754: [C++] Use lowercased `windows.h` to enable cross-platform builds

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics

https://arrow.apache.org/

Apache License 2.0

14.63k stars 3.56k forks source link

GH-44754: [C++] Use lowercased `windows.h` to enable cross-platform builds #44755

Closed evetion closed 4 days ago

evetion commented 4 days ago

Rationale for this change

<Windows.h> doesn't work cross-compiling to Windows with case-sensitive file system.

What changes are included in this PR?

Use lowercase.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

GitHub Issue: #44754

github-actions[bot] commented 4 days ago

:warning: GitHub issue #44754 has been automatically assigned in GitHub to PR creator.

conbench-apache-arrow[bot] commented 4 days ago

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 23328ff6385be2bc028faa78c51e9a8488b2af1e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.