GH-44742: [Ruby] Fix a bug that empty struct list value can't be built

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics

https://arrow.apache.org/

Apache License 2.0

14.63k stars 3.56k forks source link

GH-44742: [Ruby] Fix a bug that empty struct list value can't be built #44763

Closed kou closed 3 days ago

kou commented 4 days ago

Rationale for this change

This codes add a list value but no struct value isn't added:


require "arrow"

schema = Arrow::Schema.new(
  [
   Arrow::Field.new("structs", Arrow::ListDataType.new(
     Arrow::StructDataType.new([
       Arrow::Field.new("foo", :int64),
       Arrow::Field.new("bar", :int64)
     ])
   ))
 ]
)

Arrow::RecordBatchBuilder.build(schema, [{structs: []}])

What changes are included in this PR?

Don't add a list value.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

GitHub Issue: #44742

github-actions[bot] commented 4 days ago

:warning: GitHub issue #44742 has been automatically assigned in GitHub to PR creator.

kou commented 3 days ago

conbench-apache-arrow[bot] commented 2 days ago

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 66c2cf08d7fb3d941709b78f75230967c0fb62f4.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 11 possible false positives for unstable benchmarks that are known to sometimes produce them.