GH-44784: [C++][Parquet] Add `arrow::Result` version of `parquet::arrow::OpenFile()`

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics

https://arrow.apache.org/

Apache License 2.0

14.63k stars 3.56k forks source link

GH-44784: [C++][Parquet] Add `arrow::Result` version of `parquet::arrow::OpenFile()` #44785

Closed kou closed 2 days ago

kou commented 2 days ago

Rationale for this change

We're migrating arrow::Status + output variable API to arrow::Result API.

What changes are included in this PR?

Add arrow::Result<std::unique_ptr<FileReader>> parquet::arrow::OpenFile()
Deprecate arrow::Status parquet::arrow::OpenFile()
Use the added arrow::Result version in our code base

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

GitHub Issue: #44784

github-actions[bot] commented 2 days ago

:warning: GitHub issue #44784 has been automatically assigned in GitHub to PR creator.

kou commented 2 days ago

Good catch! I should have changed the GLib part too...

I've applied your patch with some modifications.

kou commented 2 days ago

conbench-apache-arrow[bot] commented 1 day ago

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 33e8cbb2eae70efb5ec4efc07e8fd79edb1057cf.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them.