GH-44769: [C++][Parquet] Fix read/write of metadata length footer on big-endian systems

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics

https://arrow.apache.org/

Apache License 2.0

14.63k stars 3.56k forks source link

Closed QuLogic closed 1 day ago

QuLogic commented 2 days ago

See issue.

Fix writing Parquet metadata length footer

By converting the uint32_t to little endian before casting to a uint8_t*, this is always correct in the output file.
- Fix reading Parquet metadata length footer

Yes.

Reading a Parquet file won't complain about metadata size in the footer, though that doesn't guarantee anything else will work yet.

github-actions[bot] commented 2 days ago

:warning: GitHub issue #44769 has been automatically assigned in GitHub to PR creator.

mapleFU commented 1 day ago

Rerun ci, would merge if it passes

mapleFU commented 1 day ago

Thanks all, merged!

conbench-apache-arrow[bot] commented 1 day ago

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9015a81d0e9f9a861509e5e1b6f96c0d8c01a999.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.