search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.63k stars 3.56k forks source link

[Python] Remove `use_legacy_dataset` from code base #44790

Open raulcd opened 2 days ago

raulcd commented 2 days ago

Describe the enhancement requested

We have been warning for a while about legacy dataset being deprecated since Arrow 15.0.0. Should we remove the warnings and deprecate the use_legacy_dataset keyword arguments?

Legacy dataset was removed here (from what I can find):

I haven't been able to find an issue to remove that, that's why I am opening it.

Component(s)

Python

raulcd commented 2 days ago

@jorisvandenbossche @AlenkaF is this something we might potentially want to do now? I might be able to try and find some time to do it.

raulcd commented 2 days ago

cc @pitrou

AlenkaF commented 1 day ago

I do not think we created an issue for that looking at the discussion around the use_legacy_dataset keyword arguments under this part of the review: https://github.com/apache/arrow/pull/39112#pullrequestreview-1769501660

so thanks for opening one! I think we could do this now, it has been a year since the keyword has been deprecated.