search

apache / arrow

Apache Arrow is the universal columnar format and multi-language toolbox for fast data interchange and in-memory analytics
https://arrow.apache.org/
Apache License 2.0
14.63k stars 3.56k forks source link

GH-44797: [CI] Update pkg-config to pkgconf on Homebrew #44798

Closed raulcd closed 21 hours ago

raulcd commented 1 day ago

Rationale for this change

Some CI jobs are currently failing on main:

What changes are included in this PR?

Update from deprecated pkg-config to pkgconf

Are these changes tested?

Via CI

Are there any user-facing changes?

No

github-actions[bot] commented 1 day ago

:warning: GitHub issue #44797 has been automatically assigned in GitHub to PR creator.

raulcd commented 1 day ago

weird, the C++ job passes now but the Python one still fails (and the C GLib & Ruby failure might be related)

raulcd commented 1 day ago

@kou any idea?

assignUser commented 1 day ago

@raulcd ruby uses pkg-conf via a Gem by kou and it looks like it can't find the new pkgconf. I think you can fix it by setting the envvar https://github.com/ruby-gnome/pkg-config/blob/main/lib/pkg-config.rb#L75

assignUser commented 1 day ago

For python I think it's because pkg-config is already installed via brew on the runner so it fails linking, removing pkg-config before should fix it: https://github.com/apache/arrow/actions/runs/11936401942/job/33269969915?pr=44798#step:4:65

kou commented 1 day ago

I'll improve the pkg-config gem.

kou commented 1 day ago

Hmm. Meson still uses only pkg-config: https://github.com/mesonbuild/meson/issues/7701

conbench-apache-arrow[bot] commented 14 hours ago

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit 27bbd593625122a4a25d9471c8aaf5df54a6dcf9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.