Closed malinjawi closed 3 days ago
:warning: GitHub issue #44802 has been automatically assigned in GitHub to PR creator.
@github-actions crossbow submit example-cpp-tutorial
Revision: 8acc696edd6d51bec4fbad4849e761b17ebbb2de
Submitted crossbow builds: ursacomputing/crossbow @ actions-08ec77adbe
Task | Status |
---|---|
example-cpp-tutorial |
@kou Thanks for your feedback and review. I have committed your suggested changes. Please let me know if there are any other suggestions.
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ae497bf11a4078f48b02f53b8dc843e3c0579d76.
There were 132 benchmark results with an error:
arm64-t4g-2xlarge-linux
at 2024-11-22 02:41:39Z
There were no benchmark performance regressions. 🎉
The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them.
Rationale for this change
This PR address this issue and updates the
example-cpp-tutorial
in Crossbow to resolve build failures caused by deprecated APIs, as seen in this CI job. The change migrates the examples to non-deprecated APIs to ensure compatibility with the latest Arrow C++ version.Updating these APIs is necessary to:
Fix build failures and prevent future issues. Align with the current Arrow C++ API.
What changes are included in this PR?
This PR updates the example-cpp-tutorial to replace deprecated Arrow C++ APIs with the latest supported APIs, resolving build failures in the Crossbow night build.
Are these changes tested?
By running:
output:
Are there any user-facing changes?
Yes, the tutorial has been updated to use non-deprecated APIs, which may affect the example code provided to users.