search

apache / beam

Apache Beam is a unified programming model for Batch and Streaming data processing.
https://beam.apache.org/
Apache License 2.0
7.82k stars 4.24k forks source link

Use cmp in fullvalue_test.go #20154

Open damccorm opened 2 years ago

damccorm commented 2 years ago

We could probably update the comparison helpers in fullvalue_test.go to use cmp options and Transformers instead which would make things much clearer.

Imported from Jira BEAM-9753. Original Jira may contain additional context. Reported by: danoliveira.

zhenglin-charlie-li commented 1 year ago

Hi, I am new to this project and willing to contribute.

Could you tell me more about the details? For example, what are comparison helper, cmp options, and transformers?

I looked up the original Jira but couldn't find any information about what they are. 

damccorm commented 1 year ago

The goal here would be to replace or refactor our helpers (for example https://github.com/apache/beam/blob/3b9ab77ef90519adda0255031ffc3ae598192edc/sdks/go/pkg/beam/core/runtime/exec/fullvalue_test.go#L155) to use the cmp package rather than traversing the whole object and doing reflection equality checks to compare them.

thinh2 commented 1 year ago

Hi, does this issue still open for contribution?

damccorm commented 1 year ago

@thinh2 yes, it is!