search

apache / beam

Apache Beam is a unified programming model for Batch and Streaming data processing.
https://beam.apache.org/
Apache License 2.0
7.86k stars 4.26k forks source link

Remove invalid mod type from DataChangeRecord #21618

Closed damccorm closed 2 years ago

damccorm commented 2 years ago

Remove the invalid (and unused) mod type INSERT_OR_UPDATE from the Spanner Change Streams modtype

Imported from Jira BEAM-14419. Original Jira may contain additional context. Reported by: thiagotnunes.

damccorm commented 2 years ago

Unable to assign user @thiagotnunes. If able, self-assign, otherwise tag @damccorm so that he can assign you. Because of GitHub's spam prevention system, your activity is required to enable assignment in this repo.

kennknowles commented 2 years ago

This appears to have been fixed by #17556. @thiagotnunes can you confirm?

kennknowles commented 2 years ago

In any case I do not see that this would be a release blocker unless it made things nonfunctional. But it seems that this was removing an invalid option to prevent users from choosing it. It wouldn't stop users from using valid configurations.

thiagotnunes commented 2 years ago

Yes, that was fixed already, sorry about the late reply

kennknowles commented 2 years ago

@thiagotnunes since you fixed this, could you self-assign and close it for our records?

kennknowles commented 2 years ago

Ah, now that you commented I can assign you.