apache / beam

Apache Beam is a unified programming model for Batch and Streaming data processing.
https://beam.apache.org/
Apache License 2.0
7.79k stars 4.22k forks source link

[Task]: Clean up logger handling in Python's boot.go script #29819

Open jrmccluskey opened 9 months ago

jrmccluskey commented 9 months ago

What needs to happen?

The Python SDK's boot.go script currently wraps Logging API access in a buffer to get appropriately leveled logging output sent across the logging API; however, the current structure accepts a pointer to a Logger then wraps it as needed; this should be cleaned up to pass around a buffered logger directly.

Issue Priority

Priority: 3 (nice-to-have improvement)

Issue Components

Anuragt1104 commented 8 months ago

.take-issue

ENate commented 8 months ago

Hi @jrmccluskey Is the issue still open? Thanks.

jrmccluskey commented 8 months ago

Yes this issue is still open

ENate commented 8 months ago

Since it is a 'good first issue', I can work on it. But I will have to familiarize myself with the repo. Is that okay?

jrmccluskey commented 8 months ago

Yeah of course! It's fortunately a pretty straightforward change to pass the buffered logger around instead of a normal logger and re-wrapping it consistently. If you have any questions let me know!