Open liferoad opened 7 months ago
For this particular option, the dataflow service (the UW) should be the place where you remove the option.
The Python SDK is a real mess when it comes to isolating non-GCP and GCP things. It is not a good place to use as an example.
What needs to happen?
impersonateServiceAccount
should be kept when submitting Dataflow jobs but should be removed when creating Dataflow workers per the design. To fix this, #30283 put a simple solution to remove theimpersonateServiceAccount
key from the JSON pipeline options. This introduces some Dataflow-specific concepts, which could be improved by moving it to the Dataflow-specific module. See more details in this comment.Open this issue to track this potential task to improve how to handle Dataflow-specific options in the future.
Note for Beam Python, we remove this option from the internal Dataflow apiclient module
Issue Priority
Priority: 3 (nice-to-have improvement)
Issue Components