apache / beam

Apache Beam is a unified programming model for Batch and Streaming data processing.
https://beam.apache.org/
Apache License 2.0
7.9k stars 4.27k forks source link

[Task]: Defer dataflow container tag change right before tag first candidate in release branch #30573

Closed Abacn closed 8 months ago

Abacn commented 9 months ago

What needs to happen?

Currently it is done by GitHub Action:

https://github.com/apache/beam/blame/f7fdfa7b348cf53ae6acfb06598a1145d2900504/.github/workflows/cut_release_branch.yml#L75

This has caused all Dataflow V1 job failing in cherry pick PR and release verification.

A fix is to add it to https://github.com/apache/beam/blame/master/.github/workflows/cut_release_branch.yml

However we also need other change

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

Abacn commented 9 months ago

However I don't remember Java PreCommit Dataflow failed before in release verifications. Also there are Dataflow V1 tests can pass on release branch, e.g. https://github.com/apache/beam/actions/runs/8197405771/job/22419442367?pr=30569

Likely because Dataflow switched to use v2 as default in Beam 2.54.0+

Update: actually it is root caused and fixed in #30574