In some of the tests in the JmsIOTest class (eg. https://github.com/apache/beam/blob/v2.56.0/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOTest.java#L235) there's a code that presumably asserts that the queue is empty after the test pipeline finishes its run. I believe the code there is missing a connection.start() call before calling the consumer.receiveNoWait() and thus will never see any outstanding messages in the queue. In other words, the assertNull(msg) that follows cannot ever fail.
tilgalas
commented
4 months ago
What happened?
In some of the tests in the JmsIOTest class (eg. https://github.com/apache/beam/blob/v2.56.0/sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOTest.java#L235) there's a code that presumably asserts that the queue is empty after the test pipeline finishes its run. I believe the code there is missing a
connection.start()call before calling theconsumer.receiveNoWait()and thus will never see any outstanding messages in the queue. In other words, theassertNull(msg)that follows cannot ever fail.Issue Priority
Priority: 3 (minor)
Issue Components