Closed liferoad closed 1 week ago
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer
:
R: @damccorm for label website.
Available commands:
stop reviewer notifications
- opt out of the automated review toolingremind me after tests pass
- tag the comment author after tests passwaiting on author
- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)The PR bot will only process comments in the main thread (not review comments).
Add a note here: no need to change the docker entrypoint. We can pass in --flink-conf-dir /flink-conf
directly when calling docker run
. See #33182
Tested this locally by building the
beam-flink-runner
container image and running the simple test.Created
flink-conf/flink-conf.yaml
and the yaml file contains:Then started the container:
Simple test:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.