Closed liferoad closed 1 week ago
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer
:
R: @jrmccluskey for label python.
Available commands:
stop reviewer notifications
- opt out of the automated review toolingremind me after tests pass
- tag the comment author after tests passwaiting on author
- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)The PR bot will only process comments in the main thread (not review comments).
Failed workflows are not related to this PR.
Fixes #33020 and #33021. Basically, Beam should return TypeError like
TypeError: Unable to deterministically encode '2000-01-01' of type '<class 'numpy.datetime64'>', please provide a type hint for the input of 'GroupByKey' [while running 'CreatePInput0/Map(decode)']
. The user needs to define their own deterministic coder to use this type as the groupby key.This is a hacky fix by checking whether
__getstate__
returns reasonable results.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.