Closed RustedBones closed 15 hours ago
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers
Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer
:
R: @Abacn for label java. R: @damondouglas for label io.
Available commands:
stop reviewer notifications
- opt out of the automated review toolingremind me after tests pass
- tag the comment author after tests passwaiting on author
- shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)The PR bot will only process comments in the main thread (not review comments).
Reminder, please take a look at this pr: @Abacn @damondouglas
when writing to BQ with avro, if the table schema contains
DATE
,TIME
,TIMESTAMP
columns, the default schema factory should create avro fields with matching logical type.There is still an issue with
DATETIME
:BigQueryAvroUtils::toGenericAvroSchema
favors generating schema for the reading side and generates an avro field withstring(datetime)
type. This can't be used on write (expectinglong(local-timestamp-millis)
orlong(local-timestamp-micros)
).See note in doc