MoreExecutors.directExecutor()/directExecutorService runs all tasks on the calling thread (w/o offloading to another thread for async work) and calls to submit and execute will block until the submitted task returns (i.e Runnable.run()).
Use this in test implementations of ChannelCache and FanOutStreamingEngineWorkerHarness to prevent threads waiting on each other. The old implementation seems to work locally but in the test runner environment has increased in flakiness.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
[ ] Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
MoreExecutors.directExecutor()/directExecutorService
runs all tasks on the calling thread (w/o offloading to another thread for async work) and calls tosubmit
andexecute
will block until the submitted task returns (i.eRunnable.run()
).Use this in test implementations of
ChannelCache
andFanOutStreamingEngineWorkerHarness
to prevent threads waiting on each other. The old implementation seems to work locally but in the test runner environment has increased in flakiness.Flakiness is referenced in https://github.com/apache/beam/issues/28957
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.