Open htn4179 opened 4 years ago
you can use this commit,we implement rwlock,and I commit in my fork recently
so which one is the latest? https://github.com/apache/incubator-brpc/pull/1031 or https://github.com/apache/incubator-brpc/pull/1026?
so which one is the latest? #1031 or #1026?
the implementation in 1031 will be more clear,it should be the latest
but in 1031 I got some error when travis-ci do linking like bvar_percentile_unittest.cpp:(.text+0x35): undefined reference to `bvar::detail::Percentile::Percentile()' this seems unreasonable as bavr test and bavr cc_library are not modified in my commit
so which one is the latest? #1031 or #1026?
So, I think it is your choice
@zyearn I recently repick some issue and find this rwlock is still not in brpc master. And I updated commit today for #1031 to fix some infrequent bugs which commited 2 years ago in our inner brpc. As #1031 had already stable used in our company in our inner brpc for more than 2 years, I think maybe you can merge this PR now.If there's any worry, maybe you can contact me,Thanks. FYI, #1026 is also mantained by us,but it's an experimental version, we don't use this recent 2 years.
@hairet Thanks for uploading the latest version.
we want to use bthread_rwlock_t in our program, but it seems that brpc did not implemented.