search

apache / brpc

brpc is an Industrial-grade RPC framework using C++ Language, which is often used in high performance system such as Search, Storage, Machine learning, Advertisement, Recommendation etc. "brpc" means "better RPC".
https://brpc.apache.org
Apache License 2.0
16.52k stars 3.97k forks source link

client 使用grpc 时候报ParseH2Settings error #1364

Open feng-y opened 3 years ago

feng-y commented 3 years ago

Describe the bug (描述bug)

client 使用grpc，brpc server，在server 端重启接受最新的请求时会大量包 W0325 15:15:52.053001 3101 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.219422 3060 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.292871 3139 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.315311 3072 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.355899 3090 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.379459 3145 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.448324 3094 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.550127 3115 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.553637 3096 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.556807 3069 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.611464 3124 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.746151 3125 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1 W0325 15:15:52.765209 3128 http2_rpc_protocol.cpp:211, ParseH2Settings] Unknown setting, id=65027 value=1

To Reproduce (复现方法)

Expected behavior (期望行为)

Versions (各种版本) OS: Compiler: brpc: protobuf:

Additional context/screenshots (更多上下文/截图)

zyearn commented 3 years ago

影响请求本身吗？这个是grpc的自定义setting_id，如果正常的话，对端不认识就直接忽略了。

标准的setting：https://tools.ietf.org/html/rfc7540#section-6.5

narutolhy commented 3 years ago

@zyearn 请问有办法关掉吗？或者有什么配置设置好 setting，一直报错日志比较多，影响排查问题。感谢

cdjingit commented 3 years ago

可以搞成log_every

LddBird commented 2 years ago

@zyearn 请问有办法关掉吗？或者有什么配置设置好 setting，一直报错日志比较多，影响排查问题。感谢

简单处理的话在src/brpc/policy/http2_rpc_protocol.cpp 的 H2SettingsIdentifier enum中补上 GRPC_CHTTP2_SETTINGS_GRPC_ALLOW_TRUE_BINARY_METADATA = 65027 然后ParseH2Settings中加上对应的case

看上去除了这个值以外brpc都有支持，是出于什么原因不加这个值呢？

zyearn commented 2 years ago

这个问题之前通过 https://github.com/apache/incubator-brpc/pull/1599 来避免了。

这里 @LddBird 提出的方案是更好的，有时间提一个PR吗？