遇到一个编译问题

apache / brpc

brpc is an Industrial-grade RPC framework using C++ Language, which is often used in high performance system such as Search, Storage, Machine learning, Advertisement, Recommendation etc. "brpc" means "better RPC".

https://brpc.apache.org

Apache License 2.0

16.41k stars 3.96k forks source link

遇到一个编译问题 #2648

Closed yozhao closed 4 months ago

yozhao commented 4 months ago

third_party/brpc-1.9.0/src/brpc/span.h:207:7: error: ‘class brpc::SpanFilter’ has virtual functions and accessible non-virtual destructor [-Werror=non-virtual-dtor] class SpanFilter { ^~~~~~

说 SpanFilter 没有 virtual destructor。

编译标准差异导致的？

TousakaRin commented 4 months ago

应该是编译器版本或者编译选项导致的，欢迎提个PR给他加上一个virtual destructor

lorinlee commented 4 months ago

fixed by #2651