apache / brpc

brpc is an Industrial-grade RPC framework using C++ Language, which is often used in high performance system such as Search, Storage, Machine learning, Advertisement, Recommendation etc. "brpc" means "better RPC".
https://brpc.apache.org
Apache License 2.0
16.05k stars 3.92k forks source link

Add virtual destructors to MongoServiceAdaptor and SpanFilter #2651

Closed yozhao closed 1 month ago

yozhao commented 1 month ago

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:


Check List:

yozhao commented 1 month ago

Fix non-virtual-dtor warning or error

yozhao commented 1 month ago

嗯 大意了,改过来了。

lei he @.***> 于2024年5月24日周五 14:16写道:

@.**** commented on this pull request.

In src/brpc/span.h https://github.com/apache/brpc/pull/2651#discussion_r1612875583:

@@ -206,6 +206,7 @@ void AnnotateSpan(const char* fmt, ...);

class SpanFilter { public:

  • virtual ~SpanFilter() = 0;

定义成纯虚函数最后链接会出错吧。。 virtual ~SpanFilter() = default 比较好

— Reply to this email directly, view it on GitHub https://github.com/apache/brpc/pull/2651#pullrequestreview-2075880770, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVHRJ342JMQKAAVVHLD323ZD3LKXAVCNFSM6AAAAABIG43P7GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZVHA4DANZXGA . You are receiving this because you authored the thread.Message ID: @.***>