apache / brpc

brpc is an Industrial-grade RPC framework using C++ Language, which is often used in high performance system such as Search, Storage, Machine learning, Advertisement, Recommendation etc. "brpc" means "better RPC".
https://brpc.apache.org
Apache License 2.0
16.41k stars 3.96k forks source link

fixbug: there is a ',' before 'quantile=' when labels is empty #2659

Closed renzhong closed 3 months ago

renzhong commented 4 months ago

What problem does this PR solve?

当 mbvar 的 label 为空时,mbvar latency 的 tag 会多一个逗号,导致 prometheus 无法识别这样的上报。 旧的错误格式如下: rpc_rough_rank_latency{,quantile="99"} 修复后的格式如下: rpc_rough_rank_latency{quantile="99"} Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:


Check List: