Make periodic_task.h a self-contained header file - Githubissues

apache / brpc

brpc is an Industrial-grade RPC framework using C++ Language, which is often used in high performance system such as Search, Storage, Machine learning, Advertisement, Recommendation etc. "brpc" means "better RPC".

https://brpc.apache.org

Apache License 2.0

16.56k stars 3.98k forks source link

Make periodic_task.h a self-contained header file #2758

Closed chuandew closed 2 months ago

chuandew commented 2 months ago

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed: Make periodic_task.h a self-contained header file, If others include periodic_task.h, they must include ctime header.

Side effects:

Performance effects(性能影响): No
Breaking backward compatibility(向后兼容性): Yes

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).