Only support batch butex wake with the same tag

apache / brpc

brpc is an Industrial-grade RPC framework using C++ Language, which is often used in high performance system such as Search, Storage, Machine learning, Advertisement, Recommendation etc. "brpc" means "better RPC".

https://brpc.apache.org

Apache License 2.0

16.56k stars 3.98k forks source link

Only support batch butex wake with the same tag #2778

Closed yanglimingcn closed 1 month ago

yanglimingcn commented 1 month ago

What problem does this PR solve?

Issue Number: #2777

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

Performance effects(性能影响):
Breaking backward compatibility(向后兼容性):

Check List:

Please make sure your changes are compilable(请确保你的更改可以通过编译).
When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

wwbmmm commented 1 month ago

这个修改对性能有影响吗？

yanglimingcn commented 1 month ago

这个修改对性能有影响吗？

对性能没有影响，默认butex的唤醒就是每个waiter都会signal的，只有使用CountdownEvent的时候，主动设置了void signal(int sig = 1, bool flush = false); flush=true才会有相关的影响。

wwbmmm commented 1 month ago

持续集成失败和改动有关吗？

yanglimingcn commented 1 month ago

持续集成失败和改动有关吗？

看上去不相关，主要是streaming那个case报错，我本地跑这个case没问题。

wwbmmm commented 1 month ago

LGTM