apache / buildstream-plugins

BuildStream plugins
https://buildstream.build/
Apache License 2.0
4 stars 5 forks source link

cmake, autotools, meson: Remove deprecated variables #39

Closed gtristan closed 1 year ago

gtristan commented 1 year ago

Fixes #34.

nanonyme commented 1 year ago

Your cache key values are wrong

gtristan commented 1 year ago

It’s worse than that.

the cache key values are correct, but wrong when running with newer dependencies in tox.

I’ve debugged this and narrowed it down to an issue in variable substitution, and I’ll open a separate issue for that.

gtristan commented 1 year ago

It’s worse than that.

the cache key values are correct, but wrong when running with newer dependencies in tox.

I’ve debugged this and narrowed it down to an issue in variable substitution, and I’ll open a separate issue for that.

Whew, thank god it's not that bad.

I checked:

All of this time wasted, finally I find that the problem is in the project.conf of the cache key test.

This project.conf loads the plugins via the pip origin, works fine in CI, however, in the normal case when you have a stale buildstream-plugins package locally installed from months ago when %{make-args} didn't exist, it is completely incorrect when for running python3 -m buildstream._testing._update_cachekeys to update the cache keys.