apache / buildstream

BuildStream, the software integration tool
https://buildstream.build/
Apache License 2.0
85 stars 28 forks source link

Unable to specify custom platform properties in BuildStream #1313

Open BuildStream-Migration-Bot opened 3 years ago

BuildStream-Migration-Bot commented 3 years ago

See original issue on GitLab In GitLab by [Gitlab user @jjardon] on May 16, 2020, 11:22

For more context see https://gitlab.com/remote-apis-testing/remote-apis-testing/-/issues/12#note_299577976

BuildStream-Migration-Bot commented 3 years ago

In GitLab by [Gitlab user @Qinusty] on Sep 7, 2020, 17:20

mentioned in merge request remote-apis-testing/remote-apis-testing!161

BuildStream-Migration-Bot commented 3 years ago

In GitLab by [Gitlab user @SotK] on Sep 25, 2020, 15:35

I also recently ran into this problem when trying to use BuildStream with a remote execution service with a selection of worker types which need to be selected using a custom property, https://gitlab.com/BuildGrid/buildgrid-deployments/-/tree/master/kubernetes.

BuildStream-Migration-Bot commented 3 years ago

In GitLab by [Gitlab user @tpollard] on Nov 2, 2020, 13:43

Inline with https://github.com/bazelbuild/remote-apis/blob/master/build/bazel/remote/execution/v2/platform.md it would be beneficial if bst project conf could also allow for OSFamily/ISA to be selectively disabled, as they're only 'MAY' implement conditions of a server/client. This is specific use case can be seen in remote-apis-testing, where it is mandated that only OSFamily=Linux is set (as to be able to use common worker/server implementations across clients) https://gitlab.com/remote-apis-testing/remote-apis-testing/-/merge_requests/161#note_408672086

Currently bst will add these properties based off the hosts env if not specifically defined in configuration

BuildStream-Migration-Bot commented 3 years ago

In GitLab by [Gitlab user @jjardon] on Nov 5, 2020, 17:15

marked this issue as related to remote-apis-testing/remote-apis-testing#12

BuildStream-Migration-Bot commented 3 years ago

In GitLab by [Gitlab user @tpollard] on Nov 9, 2020, 15:42

mentioned in merge request !2100