search

apache / buildstream

BuildStream, the software integration tool
https://buildstream.build/
Apache License 2.0
82 stars 27 forks source link

`bst build` appears to build same module twice #1474

Open mcatanzaro opened 3 years ago

mcatanzaro commented 3 years ago

I noticed bst 1.6.1 is building webkitgtk.bst twice at the same time:

Screenshot from 2021-05-03 16-18-29

That's twice the WebKit I had bargained for! I'm not certain, but I think it is not just a visual error: I think it really is building WebKit twice at once, because I see two separate chains of bst processes in gnome-control-center, each working on webkitgtk:

Screenshot from 2021-05-03 16-21-03

Screenshot from 2021-05-03 16-21-07

I attached two screenshots of that to show the tooltips for the two different bwrap processes that you can see are both working on webkitgtk.bst. Another clue that it's really doing a second build: my desktop was thrashing, which doesn't normally happen when building WebKitGTK via buildstream.

This is, sadly, not reproducible at all. After killing buildstream with Ctrl+C and restarting the build, it works fine, building webkitgtk.bst only once.

mcatanzaro commented 3 years ago

Abderrahim says: "I noticed this can happen if fetching the sources fails and is retried"

And that's probably exactly what happened! Something is currently wonky with DNS for webkitgtk.org, name resolution often fails and then succeeds again on the next try....

nanonyme commented 1 year ago

It seems to me this same problem still exists in bst2. And it can also happen in non-interactive mode resulting in CI building same things twice in parallel.

abderrahim commented 1 year ago

Yup, I noticed it with bst2 too (with manual retry). Don't know if it's the same issue happening in non-interactive mode.