search

apache / buildstream

BuildStream, the software integration tool
https://buildstream.build/
Apache License 2.0
85 stars 30 forks source link

Use buildbox-casd as remote asset proxy, if supported #1922

Closed juergbi closed 5 months ago

juergbi commented 5 months ago

buildbox-casd is already used as CAS proxy. Using buildbox-casd for all remote connections aims to improve robustness (e.g., consistent retry behavior) and will allow adding support for token-based authentication (#1913).

This does not yet use buildbox-casd as remote execution proxy

This depends on https://gitlab.com/BuildGrid/buildbox/buildbox/-/merge_requests/605 for the remote asset proxy to be used. However, BuildStream will fall back to direct gRPC connections if buildbox-casd doesn't support asset-only remotes.

juergbi commented 5 months ago

https://gitlab.com/BuildGrid/buildbox/buildbox/-/merge_requests/605 is now merged.

nanonyme commented 5 months ago

Is the intent there would be some kind of version check for when to enable this or what?

juergbi commented 5 months ago

Is the intent there would be some kind of version check for when to enable this or what?

The branch includes a fallback path. I.e., with older buildbox-casd it will keep using direct connections to remote asset servers.

We may want to remove the fallback path and error out with older buildbox-casd versions in the future. I think we should wait with that at least until proxy support is also added for remote execution and #1913 is complete (and buildbox and buildbox-integration have been tagged with that support).