apache / buildstream

BuildStream, the software integration tool
https://buildstream.build/
Apache License 2.0
85 stars 30 forks source link

Summary shows artifact servers which are not in use #1929

Open gtristan opened 4 months ago

gtristan commented 4 months ago

I just forgot to put my certs/keys in place before a build.

I saw:

[--:--:--][        ][    main:core activity                 ] WARNING Failed to initialize remote <url>: Failed to load credentials file: /home/tristan/work/project/certs/artifacts.key
[--:--:--][        ][    main:core activity                 ] WARNING Failed to initialize remote <url>:8980: Failed to load credentials file: /home/tristan/work/project/certs/artifacts.key

And then in the summary I had:

    Artifact cache servers
      * <url>:8980
        push: False type: storage instance: None
        loaded from: command line
      * <url>:8982
        push: False type: index instance: None
        loaded from: command line

I think this is incorrect, not sure if we should just omit this data for caches which we were unable to connect to, or perhaps we should just say connected: True or connected: False for clarity.