search

apache / camel-k-runtime

Apache Camel K runtime
https://camel.apache.org
Apache License 2.0
62 stars 50 forks source link

Revert camel-quarkus-version removal from PR #1156 #1166

Closed gansheer closed 5 months ago

gansheer commented 5 months ago

Ref #1156

Revert to fix camel-k upstream issues with catalog in nightly builds. Also camel-quarkus.version is referenced by camel-k code.

Release Note

NONE
claudio4j commented 5 months ago

yes, let's see if the revert works for the camel-k nightly builds. Maybe I overlooked it, but the maven property name camel-quarkus-version is different from the camel-quarkus.version defined in the yaml catalog (the second separator is dash), which still exits and is generated in GenerateCatalogMojo.

squakez commented 5 months ago

The error we're getting is in the catalog generation due to:

[ERROR] Plugin org.apache.camel.k:camel-k-maven-plugin:3.6.0-SNAPSHOT or one of its dependencies could not be resolved: The following artifacts could not be resolved: org.apache.camel.k:camel-k-maven-plugin:jar:3.6.0-SNAPSHOT (absent): Could not find artifact org.apache.camel.k:camel-k-maven-plugin:jar:3.6.0-SNAPSHOT -> [Help 1]: exit status 1

The problem is that maven expect the version parameter in

        <dependency>
            <groupId>org.apache.camel.quarkus</groupId>
            <artifactId>camel-quarkus-catalog</artifactId>
            <version>${camel-quarkus-version}</version>
        </dependency>
        <dependency>
            <groupId>org.apache.camel.quarkus</groupId>
            <artifactId>camel-quarkus-core</artifactId>
            <version>${camel-quarkus-version}</version>
        </dependency>

We need to understand why is that, and what kind of version we should put there in order to be aligned with the platform. Reverting completely https://github.com/apache/camel-k-runtime/pull/1156 should fix for the time being.