Clean groovy dependency and drive camel-quarkus from quarkus bom

claudio4j commented 3 months ago

the groovy deps were excluded from rest-assured deps, but that's not the case anymore
This PR removes the maven property camel-quarkus-version, while the property named in the camel-k-catalog is camel-quarkus.version, the test in the groovy script verifies it.

Release Note

NONE

lburgazzoli commented 3 months ago

I don't know what the sync_cs.sh does, for the other part LGTM

claudio4j commented 3 months ago

More context about the changes:

1) in support/camel-k-maven-plugin/pom.xml the dependency org.apache.camel.quarkus:camel-quarkus-catalog sets the version to ${camel-quarkus-version}, which may eventually be different from the version driven by quarkus-camel-bom, if there is a patch release from either projects. For the recently upstream version, this may not be a problem, but once we reach productization, this could lead to a different camel-quarkus-catalog version from the one defined in the quarkus-camel-bom. So, this change aligns the camel-quarkus-catalog version to the quarkus-camel-bom for consistency.

2) The removal of the groovy dependencies from the test module, it brings the org.apache.groovy:groovy defined in the quarkus-camel-bom, which camel-quarkus relies on. For upstream this may not be a problem, but for downstream it may lead to different groovy version in the mrrc repository which eventually have vulnerable artifacts picked up by CVE reports. So, this is good to align to the quarkus-camel-bom.

claudio4j commented 3 months ago

clear to merge ?

apache / camel-k-runtime

Clean groovy dependency and drive camel-quarkus from quarkus bom #1191