search

apache / camel-k

Apache Camel K is a lightweight integration platform, born on Kubernetes, with serverless superpowers
https://camel.apache.org/camel-k
Apache License 2.0
867 stars 348 forks source link

Should `make bundle` update kustomization.yaml? #3606

Closed squakez closed 2 years ago

squakez commented 2 years ago

As discussed in https://github.com/apache/camel-k/pull/3601#discussion_r963234805 the make bundle is adding images property. Is that correct?

squakez commented 2 years ago

Can you help @phantomjinx ?

phantomjinx commented 2 years ago

So, the changes should not be committed.

  1. The changes are transient to the kustomization config files
  2. A user is able to make use of these files without using our Makefiles by adding in their own references to the image and tag.

So the base version of the files remain under source control, while the changes come and go depending on user edits or executing make clean bundle. If I could gitignore them I would.

tadayosi commented 2 years ago

Yes, I think so too. This is the most itchy part of kustomize for me. The kustomize developers has deliberately chosen that user-customised changes are directly applied to the kustomization.yaml file. And there seems to be no way to parameterise user configs other than tainting kustomization.yaml: https://kubectl.docs.kubernetes.io/faq/kustomize/eschewedfeatures/#build-time-side-effects-from-cli-args-or-env-variables

phantomjinx commented 2 years ago

Can this be closed as asked and answered?