apache / camel-k

Apache Camel K is a lightweight integration platform, born on Kubernetes, with serverless superpowers
https://camel.apache.org/camel-k
Apache License 2.0
863 stars 344 forks source link

Ability to define K8s toleration for Builder pod #5354

Open vkrejcirik opened 5 months ago

vkrejcirik commented 5 months ago

Requirement

I'm trying to define K8s toleration for Builder pod when using Native build. I want to dedicate nodes for Native builds. Builder trait allows to define node selector, but not toleration.

Problem

When having nodes with taints, I cannot schedule Builder pods on these nodes.

Proposal

I suggest adding new parameter to Builder trait which would allow adding toleration to the Builder pod.

Open questions

No response

squakez commented 5 months ago

Thanks for reporting. If you think you can contribute by any chance, just let us know.

vkrejcirik commented 5 months ago

I think I can contribute on this one. Let me know if you can give me some more information where to start, it would speed up my work.

Thanks, Vlad

On 11. 4. 2024, at 13:05, Pasquale Congiusti @.***> wrote:

Thanks for reporting. If you think you can contribute by any chance, just let us know.

— Reply to this email directly, view it on GitHub https://github.com/apache/camel-k/issues/5354#issuecomment-2049441395, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFNNQHTS5EJL5UUBB536EDY4ZU53AVCNFSM6AAAAABGCBPCCKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZGQ2DCMZZGU. You are receiving this because you authored the thread.

squakez commented 5 months ago

I think I can contribute on this one. Let me know if you can give me some more information where to start, it would speed up my work. Thanks, Vlad

Cool. So, probably you can mimic the work done in https://github.com/apache/camel-k/pull/4968 where we were adding the NodeSelector. The logic would be the same, but, with the new field instead. Feel free to ask any support here or in zulip chat [1] where we can have a quicker interaction.

[1] https://camel.zulipchat.com/#narrow/stream/257299-camel-k

vkrejcirik commented 5 months ago

@squakez I will look into this one if that's okay.

vkrejcirik commented 4 months ago

I'm just starting to work on this one..