Closed romain-pfund closed 3 months ago
I haven't had the time to fully check with a working certificat
but the kubect get ingress xxx -o yaml seams fine when comparing to an internal working ingress (not showing here for confidentiality reason):
LGTM, thanks for the work. We need also to add the outcome of
make generate
though.
ok, so I run
make
make generate
and commit/push ?
I haven't had the time to fully check with a working certificat
but the kubect get ingress xxx -o yaml seams fine when comparing to an internal working ingress (not showing here for confidentiality reason):
Sure, the important work here is to map into the configuration expected by Kubernetes.
make make generate
and commit/push ?
Yes, you should see several autogenerated resources. They must be added to the PR, you can git commit --amend
and force push this. Also, you can see there is some minor lint error due to codestyle formatting. The check is failing with:
pkg/trait/ingress.go:22 goimports File is not `goimports`-ed
You can perform a gofmt -w pkg/trait/ingress.go
and later a make lint
to verify that is solved afterward. And again, commit the change (likely some space format).
Some builds are failing Did i missed something ?
Some builds are failing Did i missed something ?
Install check is failing because of https://github.com/apache/camel-k/issues/5632 (I'm working on a fix). The rest should be working normally. I gave it another shot.
Thanks for the contribution!
Add
Release Note