search

apache / camel-kafka-connector

Camel Kafka Connector allows you to use all Camel components as Kafka Connect connectors
https://camel.apache.org
Apache License 2.0
154 stars 102 forks source link

Kafka/Strimzi Connect - Camel example, where to put it? #117

Open mabulgu opened 4 years ago

mabulgu commented 4 years ago

Hi,

I've been thinking of adding an example of Kafka Connect Component for Strimzi and I see that there is already a doc created here: https://github.com/apache/camel-kafka-connector/blob/master/docs/modules/ROOT/pages/try-it-out-on-openshift-with-strimzi.adoc

As I had a look at the examples they seem to be just properties that connect component uses. So should we create folders per example in the examples folder like in the camel-spring-boot or camel-quarkus examples?

Or should we create the Kafka connect example for both Kafka and Strimzi in the per framework repositories like camel, camel-spring-boot or camel-quarkus?

What is your suggestion or thoughts?

valdar commented 4 years ago

Hi,

that is a good question, I think that at the moment we can have strimzi/ subfolder under examples, we can always move stuff from there elsewhere in the future if needed. What do you think @oscerd @orpiske @omarsmak ?

orpiske commented 4 years ago

@valdar I like the idea of having a separate folder for strimzi. IMHO, it gives us some flexibility about the examples we want to have, documenting and everything else.

oscerd commented 4 years ago

+1 for a strimzi folder

mabulgu commented 4 years ago

Thanks for the suggestions. So as far as I understand a strimzi folder should be created in examples folder and any examples/instructions about it should be added there?

If I understood right, and if it is all ok for you I can add this example. As I mentioned before there is already a doc that is a kind of example but, it can be extended and transformed in an example/demo format that we have in camel-spring-boot repo.

orpiske commented 4 years ago

Thanks for the suggestions. So as far as I understand a strimzi folder should be created in examples folder and any examples/instructions about it should be added there?

IMHO, yes. That's how we should organize it.

If I understood right, and if it is all ok for you I can add this example. As I mentioned before there is already a doc that is a kind of example but, it can be extended and transformed in an example/demo format that we have in camel-spring-boot repo.

Cool, looking forward to it!

valdar commented 4 years ago

@mabulgu did you have any chance to complete this?

mabulgu commented 4 years ago

Hi @valdar . Already started it but did not have a chance to continue recently. Will try to create the PR soon if it is ok for you..