code.quarkus.io badges not rendered properly

apache / camel-quarkus

Apache Camel Quarkus

https://camel.apache.org

Apache License 2.0

256 stars 189 forks source link

code.quarkus.io badges not rendered properly #2465

Open ppalaga opened 3 years ago

ppalaga commented 3 years ago

This is how it looks like e.g. here https://camel.apache.org/camel-quarkus/latest/reference/extensions/activemq.html

The SVG image from https://img.shields.io/badge/code.quarkus.io-camel%E2%80%92quarkus%E2%80%92activemq-blue.svg?logo=quarkus&logoColor=white&labelColor=3678db&color=e97826 is blocked by Camel websites's Content Security Policy
The link around the inline image is underlined which does not look well.

ppalaga commented 3 years ago

I wonder whether adding a CSP directive for https://img.shields.io would be fine for 1.? Or you maybe see other/better ways to solve this? My thoughts:

Storing the svgs locally would be doable, but having 300 similar SVGs in git does not sound very appealing
Writing a custom extension that would render the badge in pure html and css (I am not sure how to do that)? WDYT, @zregvart and @djencks ?

Problem 2. depends on how we solve 1. If we go with allowing https://img.shields.io, then we need to adjust the Camel Antora theme

ppalaga commented 3 years ago

Of course for 1., we could also use a pure text link - that's easy to do but less eye candy. I think I'll do that unless we quickly agree on a better solution.

zregvart commented 3 years ago

If you decide to go with the CSP change it needs to go here:

https://github.com/apache/camel-website/blob/7861619b7322f514409a3ff7e18027f59c7ea744/static/.htaccess#L1565

You can test it using this.