search

apache / carbondata

High performance data store solution
carbondata.apache.org
Apache License 2.0
1.43k stars 704 forks source link

[ISSUE-4305] Optimize the magic number #4307

Closed xubo245 closed 1 year ago

xubo245 commented 1 year ago

Why is this PR needed?

There are some code style， which should be optimized

What changes were proposed in this PR?

optimize the magic code in example

Does this PR introduce any user interface change?

chenliang613 commented 1 year ago

LGTM

shenjiayu17 commented 1 year ago

Build Failed with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6379/

shenjiayu17 commented 1 year ago

Build Failed with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4671/

shenjiayu17 commented 1 year ago

Build Failed with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/762/