search

apache / carbondata

High performance data store solution
carbondata.apache.org
Apache License 2.0
1.43k stars 704 forks source link

[ISSUE-4313] Add @Override for override method of processing module #4314

Closed xubo245 closed 1 year ago

xubo245 commented 1 year ago

Why is this PR needed?

There are some code smells in processing module For example 1.Didn't add @OverRide for override method 2.magic number

https://github.com/apache/carbondata/issues/4313

What changes were proposed in this PR?

 Add @Override for override method of processing module

Does this PR introduce any user interface change?

shenjiayu17 commented 1 year ago

Build Failed with Spark 2.3.4, Please check CI http://159.138.8.58:12602/job/ApacheCarbonPRBuilder2.3/6383/

shenjiayu17 commented 1 year ago

Build Failed with Spark 2.4.5, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_2.4.5/4676/

shenjiayu17 commented 1 year ago

Build Failed with Spark 3.1, Please check CI http://159.138.8.58:12602/job/ApacheCarbon_PR_Builder_3.1/768/

chenliang613 commented 1 year ago

LGTM