apache / celeborn

Apache Celeborn is an elastic and high-performance service for shuffle and spilled data.
https://celeborn.apache.org/
Apache License 2.0
886 stars 359 forks source link

[CELEBORN-1534] Order the API v1 response sequences filed #2656

Closed turboFei closed 1 month ago

turboFei commented 3 months ago

What changes were proposed in this pull request?

Make the results returned by the API v1 in order.

Why are the changes needed?

For customer interface friendly.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Not needed.

pan3793 commented 3 months ago

it might be costly for sorting shuffle_id and application_id listing API, cc @AngersZhuuuu

turboFei commented 3 months ago

it might be costly for sorting shuffle_id and application_id listing API If that, I can remove the order for them

turboFei commented 3 months ago

maybe we can sort the response in client side.

Waiting for the celeborn-CLI.

RexXiong commented 2 months ago

it might be costly for sorting shuffle_id and application_id listing API, cc @AngersZhuuuu

Perhaps we could add an option to choose between sorted and unsorted results?

github-actions[bot] commented 2 months ago

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] commented 1 month ago

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] commented 1 month ago

This issue was closed because it has been staled for 10 days with no activity.