search

apache / celeborn

Apache Celeborn is an elastic and high-performance service for shuffle and spilled data.
https://celeborn.apache.org/
Apache License 2.0
863 stars 351 forks source link

[CELEBORN-1546] Support authorization on swagger UI #2664

Closed turboFei closed 1 month ago

turboFei commented 1 month ago

What changes were proposed in this pull request?

As title.

Why are the changes needed?

Since celeborn already supports http authorization, it is better to enable authorization on swagger UI as well.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Integration testing.

image image

And it will not impact the service without authentication enabled.

image
turboFei commented 1 month ago

cc @pan3793 @cfmcgrady

turboFei commented 1 month ago 
Error:  Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.0:install-node-and-pnpm (install node and pnpm) on project celeborn-web_2.12: Could not download Node.js: Could not download https://nodejs.org/dist/v20.11.0/node-v20.11.0-linux-x64.tar.gz: Premature end of Content-Length delimited message body (expected: 46,607,807; received: 4,096,000) -> [Help 1]
cfmcgrady commented 1 month ago

Maybe we should also consider adding authorization support for Apache Kyuubi on Swagger UI? cc @pan3793

pan3793 commented 1 month ago

Thanks, merged to main