Closed SteNicholas closed 1 month ago
Ping @FMX, @AngersZhuuuu.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.34%. Comparing base (
ea6617c
) to head (8e0b09a
). Report is 13 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What changes were proposed in this pull request?
Worker#listTopDiskUseApps
should returnceleborn.metrics.app.topDiskUsage.count
applications.Why are the changes needed?
Worker#listTopDiskUseApps
returns 2xceleborn.metrics.app.topDiskUsage.count
application, which is not same asceleborn.metrics.app.topDiskUsage.count
configuration at present. Meanwhile,Worker#listTopDiskUseApps
reusesStorageManager#topAppDiskUsage
method to get the top application list used for estimated application disk usage. Therefore,Worker#listTopDiskUseApps
should return celeborn.metrics.app.topDiskUsage.count applications.Does this PR introduce any user-facing change?
No.
How was this patch tested?