Open s0nskar opened 1 month ago
@SteNicholas @waitinfuture @pan3793 wdyt about this change. We can fix this at more places incrementally.
@SteNicholas @waitinfuture ping for this ^
We can set logger levels for components. Maybe this won't be a trouble.
@FMX this mainly aims to improve the Master and Worker logging. If i want to keep such logs but don't want it in human readable way to avoid new lines.
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.
What changes were proposed in this pull request?
Adding option to choose between human friendly vs single line logging. Currently changes are done only for
WorkerInfo
andStorageManager
. I will extend these to other places as well.Why are the changes needed?
Currently lot of Celeborn logging is done in multiline format, which makes it human readable but at the same time this is not search/ingestion friendly if we process these logs they get mixed with other logs generated during same timestamp which makes it difficult to use the logs.
Ex –
Logs after ingestion
Does this PR introduce any user-facing change?
User can toggle
celeborn.humanFriendlyLog.enabled
flag to enable/disable the human friendly logging. By default it will be true to preserve the current behaviour.How was this patch tested?
Working on testing