[CELEBORN-1552] automatically support prometheus to scrape metrics for helm chart - Githubissues

apache / celeborn

Apache Celeborn is an elastic and high-performance service for shuffle and spilled data.

https://celeborn.apache.org/

Apache License 2.0

862 stars 351 forks source link

[CELEBORN-1552] automatically support prometheus to scrape metrics for helm chart #2673

Closed lianneli closed 2 weeks ago

lianneli commented 1 month ago

What changes were proposed in this pull request?

Add Annotations to Master Service and Worker Service for automatically scraping by Prometheus.
Add Ports to Worker Service, since it's empty before that prometheus cannot connect to workers.

Why are the changes needed?

Although master and worker provide http interfaces, We still need add annotations manually for prometheus automatically scraping.

Does this PR introduce any user-facing change?

No. Users will not feel any changes to install and use Celeborn.

How was this patch tested?

test locally and in dev environment.

Before:

After:

waitinfuture commented 1 month ago

@RexXiong Could you please take a look at this?