Closed turboFei closed 1 week ago
Attention: Patch coverage is 0%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 33.35%. Comparing base (
ea6617c
) to head (e4eddab
). Report is 17 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...rver/common/http/api/CelebornOpenApiResource.scala | 0.00% | 3 Missing :warning: |
...rg/apache/celeborn/server/common/HttpService.scala | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
cc @pan3793
also cc @cfmcgrady @SteNicholas
Hi @RexXiong
If no more comments, can we merge it? thanks
Hi @RexXiong
If no more comments, can we merge it? thanks
Thanks for the reminder. Merge to main(v0.6.0)
What changes were proposed in this pull request?
Using the request base url as swagger server, to prevent the swagger server not reachable and
CORS
error if the swagger server urls do not match.Currently, if the http host is bound to local, the swagger server is not reachable. For example:
Why are the changes needed?
Does this PR introduce any user-facing change?
No, just use the request base url as swagger server.
How was this patch tested?
Integration testing: