apache / celeborn

Apache Celeborn is an elastic and high-performance service for shuffle and spilled data.
https://celeborn.apache.org/
Apache License 2.0
862 stars 351 forks source link

[CELEBORN-1563] Log networkLocation in WorkerInfo #2685

Closed akpatnam25 closed 4 weeks ago

akpatnam25 commented 1 month ago

What changes were proposed in this pull request?

Log networkLocation so that it appears during worker registration

Why are the changes needed?

in the case of custom network location, it would be good to log it

Does this PR introduce any user-facing change?

How was this patch tested?

updated unit tests

akpatnam25 commented 1 month ago

cc @mridulm @FMX

akpatnam25 commented 1 month ago

test failure is unrelated

akpatnam25 commented 4 weeks ago

ping, can we merge this? :)

SteNicholas commented 4 weeks ago

@akpatnam25, thanks. Merged to main(v0.6.0) and branch-0.5(0.5.2).