Closed cxzl25 closed 2 weeks ago
Finally, there is a PR to fix this problem. BTW Are there any tools to find unused methods?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.24%. Comparing base (
ea6617c
) to head (d5686f8
). Report is 52 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Are there any tools to find unused methods
Maybe scalafix.
https://scalacenter.github.io/scalafix/docs/rules/RemoveUnused.html
Please fix the conflicts. This PR looks good to me.
Are there any tools to find unused methods
Maybe scalafix.
https://scalacenter.github.io/scalafix/docs/rules/RemoveUnused.html
Is there any relative tools for Java?
Are there any tools to find unused methods
Maybe scalafix.
https://scalacenter.github.io/scalafix/docs/rules/RemoveUnused.html
Are there any relative tools for Java?
Are there any tools to find unused methods
Maybe scalafix.
https://scalacenter.github.io/scalafix/docs/rules/RemoveUnused.html
Are there any relative tools for Java?
Isnt there not a checkstyle rule for this ?
And I just realized we dont have checkstyle for Celeborn :-) Perhaps that might help with this as well as other style enforcements ?
we dont have checkstyle for Celeborn
Because we use spotless-maven-plugin
, there may be some check conflicts with checkstyle.
In addition, .scalafmt.conf
is used in scala to check some formats.
Thanks. Merged into main(v0.6.0).
What changes were proposed in this pull request?
This PR aims to introduce
warn-unused-import
in Scala.Why are the changes needed?
There are currently many invalid imports, which can be checked using
-Ywarn-unused-import
. And throughsilencer
plugin we can avoid some imports required in scala 2.11.Does this PR introduce any user-facing change?
No
How was this patch tested?
GA