search

apache / celeborn

Apache Celeborn is an elastic and high-performance service for shuffle and spilled data.
https://celeborn.apache.org/
Apache License 2.0
862 stars 351 forks source link

[CELEBORN-1521][FOLLOWUP] Using AuthenticationException instead of SecurityException #2703

Open turboFei opened 2 weeks ago

turboFei commented 2 weeks ago

What changes were proposed in this pull request?

As title.

Why are the changes needed?

Have to use AuthenticationException to return status code 401 on auth failure, otherwise, it is 500. https://github.com/apache/celeborn/blob/9fefa66318e5c6e0f2237f63200ade8aba367e75/service/src/main/scala/org/apache/celeborn/server/common/http/authentication/AuthenticationFilter.scala#L159-L160

Does this PR introduce any user-facing change?

No, this interface has not been released.

How was this patch tested?

Existing GA.

turboFei commented 2 weeks ago

cc @pan3793