apache / celeborn

Apache Celeborn is an elastic and high-performance service for shuffle and spilled data.
https://celeborn.apache.org/
Apache License 2.0
862 stars 351 forks source link

[CELEBORN-1578] Make Worker#timer have thread name and daemon #2704

Closed cxzl25 closed 2 weeks ago

cxzl25 commented 2 weeks ago

What changes were proposed in this pull request?

Why are the changes needed?

Current jstack

"pool-36-thread-1" #118 prio=5 os_prio=0 tid=0x00007f40cc00d000 nid=0xd3e0 waiting on condition [0x00007f3ecbffe000]
   java.lang.Thread.State: TIMED_WAITING (sleeping)
        at java.lang.Thread.sleep(Native Method)
        at io.netty.util.HashedWheelTimer$Worker.waitForNextTick(HashedWheelTimer.java:600)
        at io.netty.util.HashedWheelTimer$Worker.run(HashedWheelTimer.java:496)
        at java.lang.Thread.run(Thread.java:745)

Does this PR introduce any user-facing change?

No

How was this patch tested?

GA

SteNicholas commented 2 weeks ago

@cxzl25, thanks for the contribution. Merged to main(v0.6.0), branch-0.5(v0.5.2) and branch-0.4(v0.4.3).