search

apache / celeborn

Apache Celeborn is an elastic and high-performance service for shuffle and spilled data.
https://celeborn.apache.org/
Apache License 2.0
886 stars 359 forks source link

[CELEBORN-1675] User with zero quota should not be allowed to submit any shuffle to cluster. #2857

Open Z1Wu opened 1 week ago

Z1Wu commented 1 week ago

What changes were proposed in this pull request?

In current implementation, user with zero quota still can submit one shuffle to rss cluster. It might be more reasonable to disallow users with a quota of 0 from submitting a shuffle to the RSS cluster.

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

unit-test

Z1Wu commented 1 week ago

LGTM! Please update the config docs to reflect the same.

updated

s0nskar commented 1 week ago

@Z1Wu You need to update the documentation as well using 

UPDATE=1 build/mvn clean test -pl common -am -Dtest=none -DwildcardSuites=org.apache.celeborn.ConfigurationSuite

Also, maintainers need to enable the PR workflows for this PR. ping @SteNicholas @RexXiong @FMX PTAL

Z1Wu commented 1 week ago

@Z1Wu You need to update the documentation as well using

UPDATE=1 build/mvn clean test -pl common -am -Dtest=none -DwildcardSuites=org.apache.celeborn.ConfigurationSuite

Also, maintainers need to enable the PR workflows for this PR. ping @SteNicholas @RexXiong @FMX PTAL

updated, thanks for your review.